You are correct, they were wrong in the first instance.
You do not have to be a citizen just a legal resident, they should have sold you the gun at the time your NICS check came back OK. I presume there was no further contact from BATF if it took three days, the time limit just ran out...