"I think you can still get P-38s in decent condition for under $300. Why put all that trigger time and muscle memory to waste?"
I don't mind putting in more time with another pistol. I like to shoot.
As far as getting another P-38, you're right there are plenty of them out there, one point two million of them were made during the second world war, and I think Walther was still making the P-38 into the 1990's so they are quite readily available.
However, it is definitely not my first choice as a carry weapon. It just happens to be the only pistol I own right now until I pick up my new (slightly used) Bersa on the 5th (I bought it the same day the guy traded it in and the gun shop has to hold it for two weeks).
The problems with the Walther as a carry weapon are do to its size and shape. It's chunky, has a log barrel profile for an autoloader, and the front sight snags on clothing easily. It's made as a military side arm, that's how it is best carried. If I were going to carry it I would just as soon go back to carrying my old Vaquero (gone these many years). Alternatively, if I carry an autoloader that large I may as well go to a full sized 1911, especially since the Walther can have problems with feeding anything other than full jacketed ball rounds.
I know, you can use jacketed hollow points and polish the feeding ramp, but still, that requires that I have the feeding ramp polished. If I am going to buy another gun anyway, I may as well get one that doesn't come to me needing work.
All of that being said, the P-38 can't be beat for sweet shooting accuracy. I love the weapon. Just not for carrying under my shirt.
I haven't actually applied for my concealed weapons permit yet, and simply carry my gun in my car. I should get around to applying soon and then I'll make the final decision as to my carry weapon. For home defense, as I stated in another thread, my first line weapon is a 12 gauge and the pistol is just back up.