Don't be mislead about the P38, it is probably the finest combat handgun ever made. In WW2 GI's were very pleased to get their hands on a P38. The Nazis even issued an order that any allied soldier carrying a P38 was to be shot immediately.
Today you can buy the P38's descendant, the Walther P1. at a very good price. If you search around you may find one unused and still in its NATO storage bag. Go to the "P38 Forum" on the net and the people there will be glad to help you. There are junkers around at ridiculous prices, of course, so be careful. You either buy a P38 to collect or a P1 to shoot. Make sure you chose the right gun.
Late model P38s and the P1 use aluminum frames. In early production these frames caused problems after long use. If you want a shooter, make sure you buy a gun with the steel, hexagonal shaped. reinforcing pin through the frame forward of the trigger guard.
Once you get used to the left-pointing extractor and the european magazine release you will fall in love with this pistol.
You can rest assured that the German military post WW2 and the German police force would not use anything other than THE BEST issue pistol available at the time. The P38 may be getting outdated compared with some later autos, magazine capacity, ammunition choice, etc but it is still a great pistol and full of character.