Still the biggest kid in the sandbox.
Like ll large organizations, it is imperfect. Which does not sit well with some uncompromising single-issue folks.
A person could mak a reasonable argument thata they are too close to DC; that too many of the higher-ups are buddy-buddy with too many Beltway Bandits.
However, if you are to contest bandits, you have to go where they do; you have to stand upon their ground. Bob the electrician from Cleveland in a $399 Jos. A Banks suit is not going to get traction. DC is a messed up place; the poverty index is $56K--there are janitors in DC who earn mre (but make less) than school principals out in "fly over country."
So, it's not for everybody. Luckily there are groups representing about everybody else.
You also have to be careful of naysayers--there are plenty who "know all about the NRA" yet have never actually done any research, or joined, or any such like--but, the do know what all their friends say, or heard from a buddy on the internet, or a Bernie rally.
For my 2¢, their only real vice is that they have shopped out all their marketing. Even though I know why, and approve. Far cheaper to hire direct marketing professionals than reinventing the wheel.