Value is based on a calculus of rarity and desirability that is almost impossible to describe. There are way too many subjective variables in the matrix to really be able to predict in advance what will be valuable in the future.
But, let me try a few ideas and see how they fly. This is based on my own 40 years or so of collecting, and doing pretty well financially with my choices.
First, things that are available new in quantity are not collectable.
Second, "Collectables" (like whatever engraved .45 du jour that some "historical society" is flogging in the magazines this month) are not collectable.
Third, low quality mass produced stuff is not collectable. Yes I know there are guys collecting early 1900's Iver Johnson revolvers... but... <sigh>... there's no value there and there never will be.
Leaving several more categories:
1: Things made illegal in retrospect for future, and which are grandfathered for ownership today. G Series FAL's, Open Bolt "Anythings", and registered pre-86 machine guns come to mind. Fixed or diminishing quantities and increased number of people wanting them = prices. Remember that laws change and your $10,000 maching gun can be made valueless by legislative fiat. One unintended consequence of re-opening the NFA for new machine guns would be an immediate devaluation of existing collections, for example, not that this is likely.
2: Arms produced in large quantities but then USED HARD IN A HISTORICAL EVENT THAT CAPTURES THE IMAGINATION, because at the time of original use they were utility tools and were consumed and used up without thinking of future preservation. Colt percussion revolvers come to mind as a perfect example. They were used hard in the civil war, were well worn by use, and then set aside as obsolete. Scrapped, discarded, abused, left to rust, as havuing no value. 150 years later we have high demand for them. 1903 Springfields and 1917 Enfields, Garands, original black powder Winchesters of the old west, etc. Mausers, etc., especially martial arms of all sorts.
3: Items of exquisite construction and beauty made of walnut and polished steel. Things like beautifully finished Winchesters, Colts, English Double Rifles, FN-49's, etc. No matter if civil or military, what attracts us to these is the handwork involved in the manufacture. Essentially we pay for the labor to produce a level of quality that cannot be duplicated any other way using automation. My 1906 John Wilkes .450 NE Double Rifle will always appreciate in value, for example.
4: Prototypes and one of a kind, or products of a visionary nature that were never produced in quantity. I guess as soon as the Keltec SUB-2000 is dropped from the catalog that this will be the niche they fit into. Gyrojets, Dardicks, Bren-10's, etc. This is the "ahead of the curve" collectable area. My own collection includes a variety of Belgian black powder Colt clones dating from the 1960's, known as the Centaure's. These were the first ever quality black powder replicas and were both high quality and limited production. The business venture was a failure, the products are of high quality. They sell now for more than some genuine Colts. So think out of the box. Right now "original' Carbon 15's made by Pro Ordinance are cheap, and they are VERY interesting are are not common. Buy one.. you'll thank me later.
5: Items ascribed to a particular person of fame, IE: A pistol engraved as the property of person "XX" who is well known one reason or another. Eric Chings original Scout Rifle built at Gunsite, etc.
6: Originals of what later became common. Original Colt triagular forearm AR-15's, original Belgian FN FAL's, Israeli made (not Century) Galils, Valmet AK's of all sorts (M-76's, etc), MARS CETME's., etc. Very early examples of many "common" designs are desirable.
This is the framework. I do not see much produced these days fitting into the mold, but there are a load of things produced within the last 20 years that are cheap now and appreciating. I know what I am buying, and when I have all of them I'll tell ya what they are ... ;-)
Willie
.