The P38/P1 will do fine for defense, its not the gun, its the shooter that makes the weapon effective.
Recent polymer guns have some advantages, mostly in capacity but revolvers designed in the late 1800's and the 1911 designed over a 1/4 century before the P38 all are still effective self defense guns. The P38/P1's where commercially manufactured into the 80's and could still be in production today if Walther would have adapted a hi cap magazine to it and put an accessory rail on it. The reality is there's cheaper ways to make guns using plastics so the metal frame semi's are on the decline except perhaps for 1911's and that's a niche market.
Recent polymer guns have some advantages, mostly in capacity but revolvers designed in the late 1800's and the 1911 designed over a 1/4 century before the P38 all are still effective self defense guns. The P38/P1's where commercially manufactured into the 80's and could still be in production today if Walther would have adapted a hi cap magazine to it and put an accessory rail on it. The reality is there's cheaper ways to make guns using plastics so the metal frame semi's are on the decline except perhaps for 1911's and that's a niche market.