The argument against my position (I think made my Leo Strauss at Chicago) is that, as you said, by that standard totalitarian governments are not wrong in oppressing their citizens. My response is that what is legal and what is moral are not always identical, although maybe they should be. It may have been legal to dispose of 1M peasants in the Ukraine as Stalin did but that does not make it moral. Whether Stalin violated their "rights" is rather immaterial: what difference does it make?
Your fifth and sixth paragraphs make no sense to me.
Emphasis, obviously, added by me.
This is exactly the point. If you do not recognize individual rights as existing without societal approval, then what is legal and what is moral are the same
by definition. Absent individual rights, to what standards of morality can you hold a government? The only reason to believe that a totalitarian government is in some sense "wrong" is if you also believe that they are violating the rights of their citizens. If the ability of their citizens to live, speak freely, own property, etc. only exist at the whim of society, then there is no case to be made that the totalitarian government is "wrong."
You ask what difference it makes whether Stalin violated the rights of his citizens. It makes all the difference in the world. Without the understanding that people have a right to not be murdered, how can you claim Stalin was morally wrong? No one would argue that Stalin was morally wrong if he ordered a million Ukrainian wrenches to be melted into slag, because the wrenches have no independent right to exist. If his citizens have a fundamental right to life, then what he did was wrong. If they do not, then what he did is not wrong (morally, that is).
And this is the point of my fifth paragraph (beginning "Fundamentally..."). Without a standard by which to judge the morality of government, there can be no claim that a government does anything "right" or "wrong." If the only standard by which a government is judged is whether the society it governs approves of its actions, then anything a government does is morally legitimate: "tacit consent of the governed." That is, if the people
really objected to what the government was doing, the government couldn't get away with it. Hence, society always approves of what the government does, so there is no moral check on government action.
In a strictly legal sense, I understand your point regarding "rights" being "what society, by general agreement, considers indispensable in most cases." Again in a legal sense, I'll agree with the statement: that defines what are legally considered to be rights of a citizen of a given society. The question that is unanswered by that statement, though, is whether that's the end point or the starting point. Is society's explicit recognition of something as a right required for it to be a right, or is the absence of a societal condemnation all that is required for something to be a right?
Your examples of rights being dependent upon society are interesting. The right to vote and the right to property are generally accepted in our society as individual rights, but not in many other societies. But note that both of these rights are positive rights: that is, they confer upon the citizen the ability to, in some measure, control or affect another person's rights. Generally, the understanding is that negative rights (that is, rights which relate to you not being interefered with) are inherent to the person, while positive rights are granted by an external authority.
So I will agree that the rights you list are, in fact, dependent upon society - after all, without society and a government, the right to vote is meaningless. Your right to deprive someone else of something, the right to property, is also meaningless without a social framework. I would argue, however, that your rights to not be interefered with do not depend on society. Your right to not be murdered may be much easier to defend within a society, but it doesn't lose all meaning outside of one. Ditto your right to use what you can to defend yourself, your right to pollute/not pollute your own body, your right to think what you will, your right to express those thoughts, etc.
Ultimately, the question is whether society exists to grant you rights or protect your rights. I agree with the founders that the answer to this is the latter: government exists to serve the people; the people do not exist to serve the government.