Please re-read my precise wording. I did not say that the NRA's support of competitive shooting is repelling young people. I said their overall political/cultural pitch is repelling many, many more young people than it is converting.
I feel like you're kind of whiffing on the whole point of this, which is that, if the NRA will focus on the right things (such as supporting shooting competitions), they can go back to being highly effective. Running inflamatory TV ads that threaten violence against people protesting police abuse... that's counterproductive. As is getting caught with the leadership engaged in gross personal rent-seeking.