11.c. Have you ever been convicted in any court of a felony, or any other crime, for which the judge could have imprisoned you for more than one year, even if you received a shorter sentence including probation? (See Instructions for Question 11.c.)
EXCEPTION to 11.c. and 11.i.: A person who has been convicted of a felony, or any other crime, for which the judge could have imprisoned the person for more than one year, or who has been convicted of a misdemeanor crime of domestic violence, is not prohibited from purchasing, receiving, or possessing a firearm if: (1) under the law of the jurisdiction where the conviction occurred, the person has been pardoned, the conviction has been expunged or set aside, or the person has had their civil rights
(the right to vote, sit on a jury, and hold public office) taken away and later restored AND (2) the person is not prohibited by the law of the jurisdiction where the conviction occurred from receiving or possessing firearms. Persons subject to this exception should answer “no” to 11.c. or 11.i., as applicable.
It would seem that, in accordance with Form 4473's own explanation on the back of the form, your buddy should be good to go. (If what you said is accurate.)
HOWEVER, that said, I'm no attorney and if Frank Ettin (who IS an attorney and who knows what Form 4473 says) thinks your friend should see an attorney about this, then that's what he should do.