I've been an NRA member for about 20 years. I don't recall when I upgraded to Life, but the decisions was a financial amortization one... one big cost now versus the cumulative cost for 20 or more years in the future. Each upgrade, eventually to Benefactor Life came when NRA offered a special deal for the next level of under $500 (sometimes $300) and the bonus gift was something I really wanted, such as a jacket, range bag, or backpack.
When the corruption issue became obvious, I let my wife's annual membership lapse and decided not to give another dollar to NRA until the situation was corrected, the departure of WLP being only one part of the needed correction.
I did not resign in protest as a Life Member because there are things NRA does that are still highly valuable, including the training programs (general, law enforcement, and youth programs) and the ranges and historical preservation. That last one is apparently in trouble given reports on losses from the NRA Museum act at the headquarters during the COVID closure.
WLP's resignation is not enough to fix the organization. The Board, and in particular the Executive Board and officers, have demonstrated gross incompetence or malfeasance, in particular on financial issues. They allowed WLP to play his outrageous financial games. Some of them appear to have engaged in such themselves, too.
A big example of the misuse of funds at NRA HQ is the Education& Training office, which is staffed with only four employees! Compare that to USCCA's instructor support program with apparently dozens of staff. (I have recurring contact with both.)
WLP leaving is a good beginning, but we still need to watch for impact and actions during and after the NY trial. I have my fingers crossed for long term improvement.